Skip to content

tools: fix build failure caused by PR #134420 #134816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2024
Merged

tools: fix build failure caused by PR #134420 #134816

merged 1 commit into from
Dec 27, 2024

Conversation

Integral-Tech
Copy link
Contributor

@Integral-Tech Integral-Tech commented Dec 27, 2024 •
edited
Loading

Someone reports build failure after merging pull request #134420: #134420 (comment)

This pull request fixes the build failure.

@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 27, 2024
@lqd lqd assigned lqd and unassigned Mark-Simulacrum Dec 27, 2024
@lqd
Copy link
Member

lqd commented Dec 27, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 27, 2024

📌 Commit c5e4b72 has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2024
@bors
Copy link
Collaborator

bors commented Dec 27, 2024

⌛ Testing commit c5e4b72 with merge 8dde25a...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2024
@bors
Auto merge of rust-lang#134816 - Integral-Tech:pathbuf-refactor, r=lqd
8dde25a 
tools: fix build failure caused by PR rust-lang#134420

Someone reports build failure after merging pull request rust-lang#134420: rust-lang#134420 (comment)

This pull request fixes the build failure.
@rust-log-analyzer
Copy link
Collaborator

The job dist-x86_64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
   Compiling rustc-main v0.0.0 (/Users/runner/work/rust/rust/compiler/rustc)
[RUSTC-TIMING] build_script_build test:false 0.228
[RUSTC-TIMING] tikv_jemalloc_sys test:false 0.203
[RUSTC-TIMING] rustc_query_impl test:false 233.972
rustc exited with signal: 11 (SIGSEGV)

Caused by:
Caused by:
  process didn't exit successfully: `/Users/runner/work/rust/rust/build/bootstrap/debug/rustc /Users/runner/work/rust/rust/build/bootstrap/debug/rustc --crate-name rustc_query_impl --edition=2021 compiler/rustc_query_impl/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no -C codegen-units=1 --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values())' -C metadata=f2dbc1ff599929ac -C extra-filename=-f2dbc1ff599929ac --out-dir /Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0-rustc/x86_64-apple-darwin/release/deps --target x86_64-apple-darwin -L dependency=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0-rustc/x86_64-apple-darwin/release/deps -L dependency=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0-rustc/release/deps --extern field_offset=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0-rustc/x86_64-apple-darwin/release/deps/libfield_offset-a12aa118ef2d7feb.rmeta --extern measureme=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0-rustc/x86_64-apple-darwin/release/deps/libmeasureme-044f1a97b99743ab.rmeta --extern rustc_data_structures=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0-rustc/x86_64-apple-darwin/release/deps/librustc_data_structures-b37e0fa279f55213.rmeta --extern rustc_errors=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0-rustc/x86_64-apple-darwin/release/deps/librustc_errors-95a150e8f08abb56.rmeta --extern rustc_hir=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0-rustc/x86_64-apple-darwin/release/deps/librustc_hir-36c70e75b34995ce.rmeta --extern rustc_index=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0-rustc/x86_64-apple-darwin/release/deps/librustc_index-adb2ad2519d79676.rmeta --extern rustc_middle=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0-rustc/x86_64-apple-darwin/release/deps/librustc_middle-f1808a48563adb26.rmeta --extern rustc_query_system=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0-rustc/x86_64-apple-darwin/release/deps/librustc_query_system-4b27fa30eace9c16.rmeta --extern rustc_serialize=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0-rustc/x86_64-apple-darwin/release/deps/librustc_serialize-5919eb10151cec2a.rmeta --extern rustc_session=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0-rustc/x86_64-apple-darwin/release/deps/librustc_session-7dad4caedcd4393d.rmeta --extern rustc_span=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0-rustc/x86_64-apple-darwin/release/deps/librustc_span-6b2c8f2e07244f90.rmeta --extern thin_vec=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0-rustc/x86_64-apple-darwin/release/deps/libthin_vec-7345b41b5f7e520c.rmeta --extern tracing=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0-rustc/x86_64-apple-darwin/release/deps/libtracing-3dd331fedc3ce927.rmeta --cfg=bootstrap --cfg=windows_raw_dylib -Csymbol-mangling-version=v0 -Zunstable-options '--check-cfg=cfg(bootstrap)' '--check-cfg=cfg(llvm_enzyme)' -Zmacro-backtrace -Csplit-debuginfo=unpacked '-Wrustc::internal' -Wkeyword_idents_2024 -Wunsafe_op_in_unsafe_fn -Zosx-rpath-install-name '-Clink-args=-Wl,-rpath,@loader_path/../lib' -Zon-broken-pipe=kill -Z binary-dep-depinfo -L native=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0-rustc/x86_64-apple-darwin/release/build/psm-47206a5b3cf037eb/out -L native=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0-rustc/x86_64-apple-darwin/release/build/blake3-d5ce5ce06b7dcce9/out -L native=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0-rustc/x86_64-apple-darwin/release/build/blake3-d5ce5ce06b7dcce9/out` (exit status: 254)
[RUSTC-TIMING] rustc_interface test:false 127.188
[RUSTC-TIMING] rustc_driver_impl test:false 52.882
Build completed unsuccessfully in 0:42:24
  local time: Fri Dec 27 10:12:44 UTC 2024

@bors
Copy link
Collaborator

bors commented Dec 27, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 27, 2024
@lqd lqd added the CI-spurious-x86_64-apple-SIGSEGV-SIGILL CI spurious failure: SIGSEGV/SIGILL on x86_64-apple label Dec 27, 2024
@lqd
Copy link
Member

lqd commented Dec 27, 2024 •
edited
Loading

@bors retry spurious segfault on apple builder #134220

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2024
@jieyouxu jieyouxu mentioned this pull request Dec 27, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2024
@bors
Auto merge of rust-lang#134822 - jieyouxu:rollup-5xuaq82, r=jieyouxu
6d3db55 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#134606 (ptr::copy: fix docs for the overlapping case)
 - rust-lang#134622 (Windows: Use WriteFile to write to a UTF-8 console)
 - rust-lang#134759 (compiletest: Remove the `-test` suffix from normalize directives)
 - rust-lang#134787 (Spruce up the docs of several queries related to the type/trait system and const eval)
 - rust-lang#134806 (rustdoc: use shorter paths as preferred canonical paths)
 - rust-lang#134815 (Sort triples by name in platform_support.md)
 - rust-lang#134816 (tools: fix build failure caused by PR rust-lang#134420)
 - rust-lang#134819 (Fix mistake in windows file open)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f65dc4f into rust-lang:master Dec 27, 2024
6 of 7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 27, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2024
@rust-timer
Unrolled build for rust-lang#134816
8cc9268 
Rollup merge of rust-lang#134816 - Integral-Tech:pathbuf-refactor, r=lqd

tools: fix build failure caused by PR rust-lang#134420

Someone reports build failure after merging pull request rust-lang#134420: rust-lang#134420 (comment)

This pull request fixes the build failure.
@Integral-Tech Integral-Tech deleted the pathbuf-refactor branch December 27, 2024 15:52
@Integral-Tech Integral-Tech mentioned this pull request Dec 27, 2024
Merged
poliorcetics pushed a commit to poliorcetics/rust that referenced this pull request Dec 28, 2024
@jieyouxu @poliorcetics
Rollup merge of rust-lang#134816 - Integral-Tech:pathbuf-refactor, r=lqd
8cc7626 
tools: fix build failure caused by PR rust-lang#134420

Someone reports build failure after merging pull request rust-lang#134420: rust-lang#134420 (comment)

This pull request fixes the build failure.
poliorcetics pushed a commit to poliorcetics/rust that referenced this pull request Dec 28, 2024
@bors @poliorcetics
Auto merge of rust-lang#134822 - jieyouxu:rollup-5xuaq82, r=jieyouxu
a95c44d 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#134606 (ptr::copy: fix docs for the overlapping case)
 - rust-lang#134622 (Windows: Use WriteFile to write to a UTF-8 console)
 - rust-lang#134759 (compiletest: Remove the `-test` suffix from normalize directives)
 - rust-lang#134787 (Spruce up the docs of several queries related to the type/trait system and const eval)
 - rust-lang#134806 (rustdoc: use shorter paths as preferred canonical paths)
 - rust-lang#134815 (Sort triples by name in platform_support.md)
 - rust-lang#134816 (tools: fix build failure caused by PR rust-lang#134420)
 - rust-lang#134819 (Fix mistake in windows file open)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Mar 11, 2025
@bors
Auto merge of rust-lang#134822 - jieyouxu:rollup-5xuaq82, r=jieyouxu
ec702d2 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#134606 (ptr::copy: fix docs for the overlapping case)
 - rust-lang#134622 (Windows: Use WriteFile to write to a UTF-8 console)
 - rust-lang#134759 (compiletest: Remove the `-test` suffix from normalize directives)
 - rust-lang#134787 (Spruce up the docs of several queries related to the type/trait system and const eval)
 - rust-lang#134806 (rustdoc: use shorter paths as preferred canonical paths)
 - rust-lang#134815 (Sort triples by name in platform_support.md)
 - rust-lang#134816 (tools: fix build failure caused by PR rust-lang#134420)
 - rust-lang#134819 (Fix mistake in windows file open)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lqd lqd

Labels
CI-spurious-x86_64-apple-SIGSEGV-SIGILL CI spurious failure: SIGSEGV/SIGILL on x86_64-apple S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Integral-Tech @rustbot @lqd @bors @rust-log-analyzer @Mark-Simulacrum